Add support for SMPTE-TT base64-encoded subtitles images. #1932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobbeEdgeware
force-pushed
the
added-smpte-tt-image-support
branch
from
cd20c00
to
5c42a9c
Compare
Will this test be updated or removed? |
|
@palemieux I commented out the the failing case from the MPD, so it is essentially removed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for embedded base64-encoded SMPTE-TT image element.
Tested with http://vm2.dashif.org/dash/vod/testpic_2s/img_subs.mpd
Compared to before imscJS integration, I saw the following differences:
The name space
xmlns:tts="http://www.w3.org/ns/ttml#styling"needed to be corrected (was#style#).Of the three variants on using
tts:extentandtts:origin:http://vm2.dashif.org/dash/vod/testpic_2s/img_subs_px.xml
http://vm2.dashif.org/dash/vod/testpic_2s/img_subs_percent.xml
http://vm2.dashif.org/dash/vod/testpic_2s/img_subs_div.xml
the two first still work, but the third does not since it specifies
tts:extentandtts:originin thedivelement, and this is not allowed by TTML.