Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replacing TTML parsing with imscJS library #1936

Merged
merged 17 commits into from
May 22, 2017

Conversation

TobbeEdgeware
Copy link

This is an effort to get IMSC-1 compliant by replacing our own TTML parser with imscJS.

Both text and image profiles of IMSC-1 are supported.

The SMPTE-TT image mode is also supported for legacy image subtitle sources.

The same library is also used for parsing subtitles for Smooth Streaming.

@palemieux
Copy link

@TobbeEdgeware Is there a schedule for the merge, so that an updated release of imscJS can be coordinated?

@TobbeEdgeware
Copy link
Author

@palemieux This is ready for inclusion and is decided to be in Release 2.6.0 of dash.js.

I hope @AkamaiDASH or @bbcrddave can merge the PR today or beginning of next week.

Upgrading from imscJS-1.0.0.beta.3 to to 1.0.0 can be done at any time before the 2.6.0 release.

@TobbeEdgeware
Copy link
Author

@nicosang For some reason, clahub tool does not acknowledge that you (or Orange) has signed the contribution license agreement. Can you please press the clahub "Details" link above and fill in the form (again)?

@bbert
Copy link
Contributor

bbert commented May 19, 2017

Hi,
We (Orange) signed a long time the contribution license agreement.
When we try to valid the agreement on clahub, we get an error ("We're sorry, but something went wrong")

@TobbeEdgeware
Copy link
Author

@bbert I tried with my private github account and also got a
screen shot 2017-05-19 at 11 37 06
message. However, I then refreshed the page and a got a form to fill in. Can you try that?

If it doesn't work, I'll ask @wilaw to try to fix this on the clahub side.

@bbert
Copy link
Contributor

bbert commented May 19, 2017

In order to be able to validate the CLA, CLAHub requires our Github organization (Orange-OpenSource) to allow accessing account's private data.
Our lawyers have some concerns about this situation and do not want to give the permission until the situation has been clarified. This may take some time...

@TobbeEdgeware
Copy link
Author

Since Orange has signed the CLA, and there seems to take some time to fix clahub, I merge this now.

@TobbeEdgeware TobbeEdgeware merged commit 67a63fd into development May 22, 2017
@TobbeEdgeware TobbeEdgeware deleted the imscJS-integration branch May 22, 2017 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants