-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replacing TTML parsing with imscJS library #1936
Conversation
@TobbeEdgeware Is there a schedule for the merge, so that an updated release of imscJS can be coordinated? |
@palemieux This is ready for inclusion and is decided to be in Release 2.6.0 of dash.js. I hope @AkamaiDASH or @bbcrddave can merge the PR today or beginning of next week. Upgrading from imscJS-1.0.0.beta.3 to to 1.0.0 can be done at any time before the 2.6.0 release. |
@nicosang For some reason, clahub tool does not acknowledge that you (or Orange) has signed the contribution license agreement. Can you please press the clahub "Details" link above and fill in the form (again)? |
Hi, |
In order to be able to validate the CLA, CLAHub requires our Github organization (Orange-OpenSource) to allow accessing account's private data. |
52469e0
to
1ead93b
Compare
Since Orange has signed the CLA, and there seems to take some time to fix clahub, I merge this now. |
This is an effort to get IMSC-1 compliant by replacing our own TTML parser with imscJS.
Both text and image profiles of IMSC-1 are supported.
The SMPTE-TT image mode is also supported for legacy image subtitle sources.
The same library is also used for parsing subtitles for Smooth Streaming.