update the use of streamProcessorDict in AbrController #1961
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosang
force-pushed
the
manage_StreamProcessorDict_AbrController
branch
from
0d6b0b5
to
7f3f8b8
Compare
nicosang
force-pushed
the
manage_StreamProcessorDict_AbrController
branch
from
7f3f8b8
to
f082fc2
Compare
add tests
nicosang
force-pushed
the
manage_StreamProcessorDict_AbrController
branch
from
2c75cd6
to
7b76764
Compare
robertbryer
reviewed
Jun 8, 2017
| const streamId = streamInfo ? streamInfo.id : null; | ||
| const oldQuality = getQualityFor(type); | ||
| const rulesContext = RulesContext(context).create({ | ||
| streamProcessor: streamProcessorDict[type], |
There was a problem hiding this comment.
Lack of abrController in the rulesContext causes errors in ThroughputRule.js
| if (getAutoSwitchBitrateFor(type)) { | ||
| const topQualityIdx = getTopQualityIndexFor(type, streamId); | ||
| const switchRequest = abrRulesCollection.getMaxQuality(rulesContext); | ||
| let newQuality = switchRequest.value; |
There was a problem hiding this comment.
Current development version should be switchRequest.quality
There was a problem hiding this comment.
Indeed, it 's the result of a very bad rebase....sorry!
Thanks a lot @robertbryer !
robertbryer
approved these changes
Jun 8, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR has to use, actually, streamProcessorDict attribute. Each time a streamProcessor is created,it is stored in streamProcessorDict array. So, the consequence is that the functions of AbrController just need type as parameter, not the streamProcessor reference.
Nicolas