update emsg box management #1974
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nicosang Thanks for pointing that out. The reason we removed emsg boxes in older dash.js versions was because some browsers stopped playing as soon as they encountered a box they do not know. I guess we can remove this section of the code as emsg support seems fine now. |
|
thanks @dsilhavy . Indeed, it seems to be ok for browsers if emsg box is part of mp4 segment. |
nicosang
force-pushed
the
remove_emsgbox
branch
2 times, most recently
from
b7583ff
to
a6e49df
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR has to remove properly the emsg box before to append segment in video buffer.
I'm not sure that it is really needed to remove this box. is there someone that can confirm this needed?
If it's not, I will update this PR by remove this part of the code.
Fraunhofer sample