Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding new example file to show manual load with custom settings #1986

Merged
merged 2 commits into from
Jun 9, 2017

Conversation

wilaw
Copy link
Member

@wilaw wilaw commented Jun 2, 2017

Example shows how to implement some commonly requested features:

  • disable console logs
  • enable fast switching
  • turn off segment loading while paused
  • disable autostart

Also replaces dash.edgesuite.net references with dash.akamaized.net and then removes hard-coded protocol for dash.akamaized.net and vm2.dashif.org

@wilaw wilaw merged commit 268c73a into Dash-Industry-Forum:development Jun 9, 2017
@nicosang
Copy link
Contributor

Hi @wilaw,

could you, please, take a look at DashHandlerSpec unit test? It fails after this PR.

Thanks,
Nico

@davemevans
Copy link
Contributor

could you, please, take a look at DashHandlerSpec unit test? It fails after this PR.

The problem is that the base url resolution is failing because the dummy representation doesn't have all the required information, which causes the request generation to fail. This was/is masked by having a fully-qualifed URL for the segment.

For the purposes of the test, the URL is unimportant (the semgents are never actually requested) so it's probably easiest to simply make it something like http://www.example.com/init.mp4 rather than pointing to a real world resource.

@wilaw
Copy link
Member Author

wilaw commented Jun 12, 2017

@nicosang - thanks for noticing and apologies for breaking that unit test.

@nicosang @bbcrddave
Upon further thought, as part of PR #1986, I had removed protocols from all instances of //dash.akamaized.net, as a precursors to getting the reference player not to throw mixed-content warnings for the majority of test vectors when loaded under https. I now think a better approach would be to actually hard code these all to https. This would be robust over both http and https usage of the ref player, it looks more conventional in the example files/readme/playerUI and it would fix the unit test issue noted above. If you agree, I will create a new PR to this end.

@nicosang
Copy link
Contributor

it's ok for me.

@wilaw
Copy link
Member Author

wilaw commented Jun 15, 2017

#2001 should resolve this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants