Fix segment timeline #1991
Merged
Fix segment timeline #1991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 8 commits
June 6, 2017 20:29
Must use arguments with default at the end, but I'd rather not change this method signature.
|
@AxelDelmas looks cleaner but have not pulled and played with it. When you have time please resolve the conflicts and I can merge if you feel confident in the changes |
# Conflicts: # src/dash/utils/SegmentsUtils.js # src/dash/utils/TimelineSegmentsGetter.js
|
done! |
|
Thanks @AxelDelmas |
jeremco
added a commit
to Orange-OpenSource/dash.js
that referenced
this pull request
Jul 13, 2017
…ash-Industry-Forum#1991). Representation segment list is now updated in processTfrf function, if timeline is updated
5 tasks
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt to fix #1916
Here's basically what's in this PR