Improve unit tests #1997
Merged
Improve unit tests #1997
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosang
force-pushed
the
improve_tests
branch
3 times, most recently
from
bfea22d
to
8314d24
Compare
… getIsDynamic functions.
…etEventStreamForRepresentation functions.
…sentationsForAdaptation functions.
…er is missing = > what is the best ?
- DashManifestModel - XHRLoader
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR has to improve unit tests for DashManifestModel class by adding a check of the parameters. Some errors may occur during development round, maybe it could be better to throw an error......
Some others unit tests have been added.
Nicolas