bug fix #2028 #2029
bug fix #2028 #2029
Conversation
src/dash/models/DashManifestModel.js
Outdated
| @@ -41,6 +41,12 @@ import ObjectUtils from '../../streaming/utils/ObjectUtils'; | |||
| import URLUtils from '../../streaming/utils/URLUtils'; | |||
| import FactoryMaker from '../../core/FactoryMaker'; | |||
|
|
|||
| Number.isInteger = Number.isInteger || function (value) { | |||
There was a problem hiding this comment.
I would prefer to see a local function within DashManifestModel to avoid modifying Number within dash.js.
function DashManifestModel(config) {
const isInteger = Number.isInteger || function (value) { ...
...
if (realAdaptations && isInteger(index)) { ...
There was a problem hiding this comment.
Hi @bbcrddave ,
if the function Number.isInteger is undefined in a specific browser, define a polyfill function could be useful in a another part of javascript code. In this case, it could be cleaner to put this polyfill function in a specific file (in utils folder).
On another side, this function is currently only use in DashManifestModel. So, your option could indeed be selected.
In any case, if Number.IsInteger is already defined, we don't override it.
Nicolas
There was a problem hiding this comment.
I've moved this polyfill function in the DashManifestModel as expected by mostly people. ;-)
in some browsers, Number.isInteger function is not defined.
This PR fix the issue #2028