Fix issue # 1938 - MSS with dvrWindowsSize = 0 #2040
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…_0500.isml/Manifest It has to be noticed that using this stream, some fragments are quite long (10s) and sometimes getFragmentRequestForTime doesn't return the right fragment correpsonding to time, but the previous one, because of threshold in FragmentModel:getRequestForTime. That's why there is a loop in nextFragmentRuel, to get the first next not loaded fragment. Another point is buffer parameters are : "liveDelay": 18, "stableBufferTime": 16, "bufferTimeAtTopQuality": 16, "bufferTimeAtTopQualityLongForm": 16
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
This PR solves a pb encountered by @qchroman (cf Issue #1938) , when playing streams
https://djkxw9frc3oss.cloudfront.net/live/live.isml/Manifest
https://djkxw9frc3oss.cloudfront.net/live/Sintel_0500.isml/Manifest
It has to be noticed that using these streams, some fragments are quite long (10s) and sometimes getFragmentRequestForTime doesn't return the right fragment corresponding to time, but the previous one, because of threshold in FragmentModel:getRequestForTime. That's why there is a loop in nextFragmentRuel, to get the first next not loaded fragment.
Another point is buffer parameters are :
"liveDelay": 18,
"stableBufferTime": 16,
"bufferTimeAtTopQuality": 16,
"bufferTimeAtTopQualityLongForm": 16