Update subtitles management #2132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosang
force-pushed
the
update_Subtitles
branch
3 times, most recently
from
f1088a6
to
f43a0d7
Compare
|
@nicosang, would it be possible squashing consecutive commits with same description into one? Just trying to keep commits history as cleaner as possible. Thanks! |
nicosang
force-pushed
the
update_Subtitles
branch
3 times, most recently
from
152ed5b
to
dbee4e9
Compare
|
@epiclabsDASH, It should be better now.... ;-) |
|
Many thanks! |
… element. add functions to videoModel class in order to protect access to video element.
…done by textController
video reference is not needed
update setTexTrack function
nicosang
force-pushed
the
update_Subtitles
branch
from
dbee4e9
to
a8767b4
Compare
|
Good fix, @nicosang. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR has to fix the issue #2084 : the index of the subtitles track is a reference of textTrackInfo array. textTrack array of html5 video element has a different index.
In the same way, user can use the different subtitles with Firefox or Edge for instance. Indeed, before this PR, it was impossible to see subtitles in some specifc use cases (for instance, a first stream with one subtitles track, stop, load a second one, with two subtitles track).
Nicolas