add test when data to parse is equal to null #2143
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosang
force-pushed
the
UpdateDashParserUnitTest
branch
from
bc5f5a9
to
a179f2a
Compare
test/unit/dash.DashParser.js
Outdated
| it('should throw an error when parse is called and config object has not been set properly', function () { | ||
| expect(dashParser.parse.bind('')).to.be.throw('Missing config parameter(s)'); | ||
| }); | ||
|
|
||
| it('should throw an error when parse is called without data and config object has been set properly', function () { | ||
| let errorHandlerMock = new ErrorHandlerMock(); |
There was a problem hiding this comment.
Minor stuff. Could you please declare it as const?
epiclabsDASH
approved these changes
Aug 31, 2017
test/unit/dash.DashParser.js
Outdated
| it('should throw an error when parse is called and config object has not been set properly', function () { | ||
| expect(dashParser.parse.bind('')).to.be.throw('Missing config parameter(s)'); | ||
| }); | ||
|
|
||
| it('should throw an error when parse is called without data and config object has been set properly', function () { | ||
| let errorHandlerMock = new ErrorHandlerMock(); |
There was a problem hiding this comment.
Minor stuff. Could you please declare it as const?
nicosang
force-pushed
the
UpdateDashParserUnitTest
branch
from
80b6302
to
dbdb9e3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.