Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix typo in unit test #2147

Merged

Conversation

squarebracket
Copy link
Contributor

Enough said, I think. It was causing tests to fail. Not sure how Travis was passing.

@epiclabsDASH
Copy link
Contributor

Good catch! Thanks for the fix.

@squarebracket, just one more thing. Given you are already working with this, do you matter modifying test/unit/streaming.controllers.XLinkController.js and replace any reference to XLinkController with XlinkController?

This is:

  • Name of imported class in import XlinkController from '../../src/streaming/controllers/XlinkController';
  • describe('XLinkController',...

@squarebracket
Copy link
Contributor Author

Ah, I figured XLinkController was the right name since the test passed. Sure, I'll rename everything to use the properly-cased class name.

@epiclabsDASH
Copy link
Contributor

Thanks!

@squarebracket
Copy link
Contributor Author

Done. I'm in a "training session" so you might want to make sure I got it all right :P

@epiclabsDASH epiclabsDASH self-requested a review August 30, 2017 07:55
Copy link
Contributor

@epiclabsDASH epiclabsDASH left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine. Thanks!

@dsparacio
Copy link
Contributor

@epiclabsDASH - We want this pulled for 2.6 right? Go ahead and merge and Ill push new RC for consistency but really not needed.

@epiclabsDASH epiclabsDASH merged commit 3fb6e22 into Dash-Industry-Forum:development Aug 31, 2017
@epiclabsDASH
Copy link
Contributor

Done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants