Add Jshint and Jscs to unit test folder #2152
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Great, thanks for the change. I need to review it deeply but definitively this is something that we needed and that will help to keep good quality of the code. |
nicosang
force-pushed
the
addJShintOnUnitTestFolder
branch
2 times, most recently
from
1699044
to
5ad3ff6
Compare
nicosang
force-pushed
the
addJShintOnUnitTestFolder
branch
2 times, most recently
from
4f2f0fd
to
6145ea4
Compare
nicosang
force-pushed
the
addJShintOnUnitTestFolder
branch
from
6145ea4
to
c167e44
Compare
update syntax to respect rules for jshint and jscs
nicosang
force-pushed
the
addJShintOnUnitTestFolder
branch
from
85e504d
to
02def90
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR offers the possibility to respect coding rules in unit test files.
Nicolas