Update module management #2154
Merged
Update module management #2154
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosang
force-pushed
the
UpdateModuleManagement
branch
2 times, most recently
from
4251227
to
ef740be
Compare
|
The size of each module is decreased significantly with this PR due to the reduction of classes duplication in each module. |
nicosang
force-pushed
the
UpdateModuleManagement
branch
from
989ead5
to
9ec7c20
Compare
|
@nicosang, could you please resolve conflicts that appeared? |
…o Events.js (core) in Mss module.
…o Events.js (core) in Protection module.
…emove reference to Events.js (core) in Reporting module.
…n module. reference is set by config object in order to remove the duplication of classes.
reference is set by config object in order to remove the duplication of classes.
reference is set by config object in order to remove the duplication of classes.
reference is set by config object in order to remove the duplication of classes.
reference is set by config object in order to remove the duplication of classes.
reference is set by config object in order to remove the duplication of classes.
reference is set by config object in order to remove the duplication of classes.
reference is set by config object in order to remove the duplication of classes.
use global dashjs.FactoryMaker definition
reference is set by config object in order to remove the duplication of classes.
use global dashjs.FactoryMaker definition
reference is set by config object in order to remove the duplication of classes.
use global dashjs.FactoryMaker definition
…odule. reference is set by config object in order to remove the duplication of classes.
nicosang
force-pushed
the
UpdateModuleManagement
branch
from
9ec7c20
to
18ec4ca
Compare
|
@epiclabsDASH, should be ok now. |
…orting and protection files.
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
as explained in issue #2133, loading by module of dash.js was impossible. The management of events was the blocker. In order to solve this problem, I suggest to remove Events.js and MediaPlayerEvents.js references from modules (Reporting, Mss, Protection). references of events are set by config object in all modules.
Nicolas