[DRM] Ignore 'encrypted' event #2165
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… selected and pssh already processed. This avoids to call requestKeySystemAccess each time an init segment is pushed in sourcebuffer (each time bitrate is changed) This may lead to a crash of CDM
|
@jeremco this seems like a good fix, noticed this last week doing some heavy DRM stuff. Ill pull test, review and merge. Thanks for this |
epiclabsDASH
approved these changes
Sep 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
This PR ignores 'encrypted' event in case the key system has already been selected and pssh already processed.
This avoids to call requestKeySystemAccess each time an init segment is pushed in sourcebuffer (each time bitrate is changed)
This may lead to a crash of CDM.
This can be the cause of issue #2159
Jeremie