add a SwitchHistoryRule unit test #2181
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epiclabsDASH
suggested changes
Sep 21, 2017
| it("should return an empty switchRequest when getMaxIndex function is called with an empty parameter", function () { | ||
| const switchRequest = switchHistoryRule.getMaxIndex(); | ||
|
|
||
| expect(switchRequest.quality).to.be.equal(-1); // jshint ignore:line |
There was a problem hiding this comment.
@nicosang, thank you very much. PR looks great. Just one minor proposal. Could we use SwitchRequest.NO_CHANGE here instead of -1?
epiclabsDASH
approved these changes
Sep 22, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
in issue #2178, a division by zero has been detected, that is why a SwitchHistoryRule unit test is added. I don't know exactly what is expected because in javascript a division by zero returns INFINITY, not really an error.
Nico