Safer DOMStorage.js

[robertbryer]

Don't trust the contents of local storage to be uncorrupted, assume parseInt can throw, parseFloat can throw, extend the try-catch around them.

[nicosang]

Hi @robertbryer,
according to parseInt and ParseFloat documentation, thoses functions don't throw errors.....but JSON.parse can indeed throw an error. could you, please, update the DOMStorage unit test with a mock localStorage?
I have an other question why do you move the bracket in this line?
const obj = JSON.parse(localStorage.getItem(key) || {});

Thanks,
Nico

[robertbryer]

Sorry, I'm getting confused here - I don't have the || {} in my branch!

[epiclabsDASH]

@robertbryer, just to check with you. If you are working on adding localStorageMock and unit tests related with it, as suggested by @nicosang, please, merge your branch with development one. There are some recent changes in development branch related with enforcing coding rules for tests and that could break development branch compilation after merging this PR.