Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fix about start time #2194

Merged
merged 1 commit into from
Sep 28, 2017
Merged

Bug fix about start time #2194

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 10 additions & 5 deletions src/streaming/controllers/PlaybackController.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -445,6 +445,8 @@ function PlaybackController() {
return false;
}
function onBytesAppended(e) {
let earliestTime,
initialStartTime;
let ranges = e.bufferedRanges;
if (!ranges || !ranges.length) return;
if (commonEarliestTime[streamInfo.id] === false) {
Expand Down Expand Up @@ -472,19 +474,20 @@ function PlaybackController() {
const hasAudioTrack = streamController.isAudioTrackPresent();

if (hasAudioTrack && hasVideoTrack) {
//current stream has audio and video contents
if (!isNaN(commonEarliestTime[streamInfo.id].audio) && !isNaN(commonEarliestTime[streamInfo.id].video)) {

let earliestTime;
let ranges;
initialStartTime = getStreamStartTime(false);

if (commonEarliestTime[streamInfo.id].audio < commonEarliestTime[streamInfo.id].video) {
// common earliest is video time
// check buffered audio range has video time, if ok, we seek, otherwise, we wait some other data
earliestTime = commonEarliestTime[streamInfo.id].video;
earliestTime = commonEarliestTime[streamInfo.id].video > initialStartTime ? commonEarliestTime[streamInfo.id].video : initialStartTime;
ranges = bufferedRange[streamInfo.id].audio;
} else {
// common earliest is audio time
// check buffered video range has audio time, if ok, we seek, otherwise, we wait some other data
earliestTime = commonEarliestTime[streamInfo.id].audio;
earliestTime = commonEarliestTime[streamInfo.id].audio > initialStartTime ? commonEarliestTime[streamInfo.id].audio : initialStartTime;
ranges = bufferedRange[streamInfo.id].video;
}
if (checkTimeInRanges(earliestTime, ranges)) {
Expand All @@ -493,8 +496,10 @@ function PlaybackController() {
}
}
} else {
//current stream has only audio or only video content
if (commonEarliestTime[streamInfo.id][type]) {
seek(commonEarliestTime[streamInfo.id][type]);
earliestTime = commonEarliestTime[streamInfo.id][type] > initialStartTime ? commonEarliestTime[streamInfo.id][type] : initialStartTime;
seek(earliestTime);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nicosang This bug still presents for me. I'm using 2.6.4 and my video has no audio track. Could it be because in the audo/video-only case it doesn't do the checkTimeInRanges check before seeking while in the audio and video case it does?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's an example from my debug log where the video goes from 171.379s (intended time) to 168s (start of segment).

[223] Getting the request for video time : 171.379 
[224] Index for video time 171.379 is 42 
[225] SegmentList: 168 / 349.267 
[226] ScheduleController video- getNextFragment - request is https://d11xfn549clyq.cloudfront.net/59efaac067282406f479dd24/video5400_dash.mp4 
[698] Buffered Range for type: video : 168  -  171.999999 
[699] Got enough buffer to start. 
[699] Requesting seek to time: 168 
[700] Seeking to: 168

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hi @dpieri ,

I tested with audio only sample streams. I'm not able to reproduce your issue. Could you, please, provide us your video only sample stream?

Thanks,
Nico

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm actually able to reproduce it on the Big Buck Bunny example, which is strange because it has audio and video.

Notice how the code sets the video element's currentTime to 21, but the video usually starts at 16. When I open in a new browser it actually starts at 0, so it must be a race condition that depends on how much of the video is cached.

You can change line 6 to try other start times and it seems to always jump to something before the time you choose.

https://codepen.io/anon/pen/eyYYVQ

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@dpieri , I see....I think there is a misunderstood. What this PR fixed, was the use of the "#t=startTime" parameter at the end of the manifest url. In this case, if you set url like 'https://dash.akamaized.net/akamai/bbb_30fps/bbb_30fps.mpd#t=21', you'll see that it works correctly.

Your use case could be an another issue to inspect....please, open a new one.

Thanks,
Nico

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Done

commonEarliestTime[streamInfo.id] = false;
}
}
Expand Down