Allow preload of Dash media without a video element #2274

robertbryer · 2017-11-07T16:01:31Z

This pull request adds preload() to the player, which initialises the streaming portion of the player without a video element, so implementors can have a media item ready for immediate playback when a view is eventually attached.

Example:

var player = dashjs.MediaPlayer().create();
player.initialize(null, url, true);
player.preload();
//After a delay to load content
player.attachView($('video'))

SourceBufferController is removed, replaced by SourceBufferSink and PreBufferSink, two classes implementing a new FragmentSink interface. There are a few changes elsewhere to not assume the existence of a video element. Some PLAYBACK_NOT_INITIALIZED errors from mediaplayer.js are now STREAMING_NOT_INITIALIZED, but otherwise no other aspect of the API has changed.

davemevans · 2017-11-07T16:10:18Z

src/streaming/text/NotFragmentedTextBufferController.js

 import EventBus from '../../core/EventBus';
 import Events from '../../core/events/Events';
 import FactoryMaker from '../../core/FactoryMaker';
 import InitCache from '../utils/InitCache';
+import SourceBufferSink from '../SourceBufferSink';
+import TextController from '../../Streaming/Text/TextController';


Paths are case sensitive on some platforms. This seems to be causing the tests to fails.

epiclabsDASH · 2017-11-13T16:32:03Z

@robertbryer, sorry, a conflict appeared since one of latest merges.

epiclabsDASH · 2017-11-27T13:26:35Z

src/streaming/SourceBufferSink.js

+
+/**
+ * The an end place to put fragments after they have been fetched.
+ * @interface FragmentSink


@robertbryer, we could move this interface definition to be in its own file as we do for others like ProtectionController or KeySystem. What do you think?

Sure - is the position of the sinks ok in /streaming ? Shall I make /sinks or /controllers/sinks ?

…BufferController to SourceBufferSink, make everything work without mediaelement/source

…d in time order

Fix buffer pruning problems

…ome don't like tracks to be added after decoding has started

Fix reset problems Sort out subtitles and their unit tests

…ce SOURCEBUFFER_APPEND_COMPLETED by local callback, don't store appendedBytesInfo, pass through callback instead

robertbryer · 2018-02-15T17:46:51Z

Hi @epiclabsDASH, I've rebased and improved the documentation, can you review and merge it in for v2.6.7?

robertbryer · 2018-02-15T17:48:35Z

test/unit/streaming.controllers.BufferControllerSpec.js

@@ -446,12 +412,9 @@ describe('BufferController', function () {
            eventBus.trigger(Events.PLAYBACK_SEEKING);
        });

+        /*


Also, not sure what to do here; doesn't seem like a valid test when the buffer is getting cleared out on seek?

Let me take a look at this part. Structure of the test seems to be ok but I need to take a deeper look.

epiclabsDASH · 2018-02-15T18:26:25Z

Sure, I have this scheduled for 2.6.7. Thanks for this contribution!

epiclabsDASH · 2018-02-21T14:01:28Z

@robertbryer, I am doing some tests but am having some problems when attaching the view to the MediaPlayer. If I attach the view a 1-2 seconds after initializing I get CHUNK_DEMUXER_ERROR_APPEND_FAILED errors. If I wait more, everything starts correctly but after playing for a few seconds video starts showing decoding artifacts.

Seems like what dash.js is inserting in the SourceBuffer is not correct.

In the meantime, could you please bring latest dev changes to this branch. There are some changes related with the way the requests are synced that changed recently.

Following with the plan of adding this PR in 2.6.7 I will continue testing it in different scenarios. I will get back to you as soon as I have more feedback.

Thanks!

robertbryer · 2018-02-21T16:10:18Z

Yeah, I'll get on this. It's dropping the init segment if there's no video segments in the prebuffer. I guess my internet is too speedy to notice this...

…gment is pre-buffered

robertbryer · 2018-02-23T16:22:59Z

@epiclabsDASH - Fixed!

epiclabsDASH · 2018-02-26T15:18:59Z

@robertbryer, worked like a charm after your latest changes (and before the latest merge brought new conflicts).

@robertbryer, I will merge this after conflicts are resolved. Thanks and sorry for the multiple "resolve conflicts" tasks...

davemevans reviewed Nov 7, 2017

View reviewed changes

epiclabsDASH added the Feature Enhancement label Nov 7, 2017

epiclabsDASH reviewed Nov 27, 2017

View reviewed changes

epiclabsDASH added this to the v2.6.5 milestone Nov 27, 2017

epiclabsDASH modified the milestones: v2.6.5, v2.6.6 Jan 3, 2018

epiclabsDASH modified the milestones: v2.6.6, v2.6.7 Jan 30, 2018

robertbryer added 21 commits February 9, 2018 11:19

First attempt at media preloading, add PreBufferSink, refactor Source…

c895353

…BufferController to SourceBufferSink, make everything work without mediaelement/source

Remove/update other references to SourceBufferController

7f6f23b

Don't check element size when we don't have a videoModel

308cdc9

WIP on unit tests; pair init fragments in pre-buffer, guarantee appen…

7bef314

…d in time order

Fix buffering issue, make more unit tests work

5b1a5c6

Don't use lack of videoModel as a proxy for lack of an element

ba00323

Fire buffer loaded events only when loaded into mediasource buffer

1a28d08

Make discharge accept null argument for all time

d90acf4

Replace the currentWorkingTime thingy

adc1b55

Add preload function to api to activate preloading

55fa4f9

Fix buffer pruning problems

Make the mediasource buffers first, then start discharging, because s…

36d0fa4

…ome don't like tracks to be added after decoding has started

Try to help IE11 remove source buffers

5c11ce1

Fix reset problems Sort out subtitles and their unit tests

Fix merge errors, fix unit test styling errors

b0010bf

Fix merge errors, fix unit test styling errors

678a3cc

Timestamp offset storage not needed

8a04433

More test cleanup

20e5d5e

Fix path capitalisation

e6cbd66

Bad merge, not preloading

c8ef90c

Don't start preloading content if there's no video element

84d8980

Fix issue where preloading to the end of media wouldn't end it, repla…

8ce592f

…ce SOURCEBUFFER_APPEND_COMPLETED by local callback, don't store appendedBytesInfo, pass through callback instead

Fix rebase issues

948d0b2

Fix rebase issues

78106f8

robertbryer force-pushed the preload branch from 3e7f02d to 78106f8 Compare February 13, 2018 14:55

robertbryer added 5 commits February 13, 2018 15:00

Remove some stray sourceBufferController references

96ac40d

Fix preload discharge

1c5eed6

Move interface definition, clean up documentation

de07385

Merge branch 'development' into preload

5464991

Fixup style

85e0057

robertbryer commented Feb 15, 2018

View reviewed changes

Stop losing all the buffer from fragment model on sync

486c210

robertbryer added 3 commits February 23, 2018 14:48

Fix issue where init segments get lost when no corresponding media se…

e9a9888

…gment is pre-buffered

Merge branch 'development' into preload

4468b8c

Fix jump-gaps

4686bc6

robertbryer and others added 6 commits March 2, 2018 11:06

Merge branch 'development' into preload

23b7c8a

Fix track switching merge

7ca03f1

And fix the switch at end of buffering case

153d42d

Fix lint

06de370

Add preload feature sample

3555c4a

Add preload method to type definitions

a2fddf5

epiclabsDASH merged commit 3bc8b8e into Dash-Industry-Forum:development Mar 5, 2018

nicosang mentioned this pull request Mar 14, 2018

Vtt subtitles bug fix #2467

Merged

epiclabsDASH mentioned this pull request Mar 15, 2018

Fix creation of buffers #2473

Merged

epiclabsDASH mentioned this pull request Mar 24, 2018

Is there a way to preload the initial segments without attaching a view? #1421

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow preload of Dash media without a video element #2274

Allow preload of Dash media without a video element #2274

robertbryer commented Nov 7, 2017

davemevans Nov 7, 2017

epiclabsDASH commented Nov 13, 2017

epiclabsDASH Nov 27, 2017

robertbryer Nov 27, 2017

robertbryer commented Feb 15, 2018

robertbryer Feb 15, 2018

epiclabsDASH Feb 15, 2018

epiclabsDASH commented Feb 15, 2018

epiclabsDASH commented Feb 21, 2018

robertbryer commented Feb 21, 2018

robertbryer commented Feb 23, 2018

epiclabsDASH commented Feb 26, 2018

Allow preload of Dash media without a video element #2274

Allow preload of Dash media without a video element #2274

Conversation

robertbryer commented Nov 7, 2017

davemevans Nov 7, 2017

Choose a reason for hiding this comment

epiclabsDASH commented Nov 13, 2017

epiclabsDASH Nov 27, 2017

Choose a reason for hiding this comment

robertbryer Nov 27, 2017

Choose a reason for hiding this comment

robertbryer commented Feb 15, 2018

robertbryer Feb 15, 2018

Choose a reason for hiding this comment

epiclabsDASH Feb 15, 2018

Choose a reason for hiding this comment

epiclabsDASH commented Feb 15, 2018

epiclabsDASH commented Feb 21, 2018

robertbryer commented Feb 21, 2018

robertbryer commented Feb 23, 2018

epiclabsDASH commented Feb 26, 2018