[text tracks] take into account the video element parent container s… #2291
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ze and the relative offset between them
src/streaming/models/VideoModel.js
Outdated
| } | ||
|
|
||
| function getVideoRelativeOffsetLeft() { | ||
| return element && element.parentNode ? element.getBoundingClientRect().x - element.parentNode.getBoundingClientRect().x : NaN; |
There was a problem hiding this comment.
@jeffcunat,Looking at MDN (https://developer.mozilla.org/en-US/docs/Web/API/Element/getBoundingClientRect) seems object returned by getBoundClientRect() doesn't include x/y properties in Edge/IE/Safari.
|
@epiclabsDASH your remark is good, and I will use element.getBoundingClientRect().top and .left that is more widely used. I have also some other improvements ongoing |
…nd manage changes of the video element position relatively to its parent (during resize)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue #2241
This PR takes into account the fact that the parent container of the video element can have a different size than the video element itself.
It also takes into account the relative positioning of the video element inside its parent (ex: vertically centered video element in fullscreen mode)
@Gontran-Molotov : could you check if it is OK for your use cases ?