Update the use of isTypeSupported function #2328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ht value. MediaSource.isTypeSupported used those values. For firefox, high video resolutions (height>1080) are not supported.
|
I don't understand how this is ok but not for EME?https://w3c.github.io/media-source/isobmff-byte-stream-format.html#mime-parameters references the same RFC as in #2329? |
|
Hi @bbcrddave , the problem is on MediaKeySystemConfiguration.videoCapabilities attribute, used for the call to requestMediaKeySystemAccess function. contentType parameter seems not support width and height.... :-( Nico |
|
Yep. Anyway that's something that need more research. Given both reference same RFC doesn't make too much sense that something that works for isTypeSupported doesn't work for requestMediaKeySystemAccess. Seems more a limitation/issue in the browser side. I will take a deeper look and report the issue in Chrome/Firefox in case this is needed. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
MSE isTypeSupported function manage a codec parameter with width and height values. This PR adds thoses values in order to fix a bug in firefox 57 with high resolutions #2323.
Nico