#2330 Add 'r' parameter to specify relative start time in a live stream #2403
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
|
A useful convention often used with time offsets is that negative offset means start from the other end. Perhaps this might also be useful here? That is, so one could specify |
|
Good point, @sandersaares, I agree that behavior could be useful, both for r and s parameter. We can skipt t parameter because it is focused on absolute times. We will push another PR with that change. Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new parameter 'r' to specify relative start time of a live stream as specified in #2330. This parameter has a value between 0 and the DVR window size in seconds.
Also, it fixes a problem when the live stream play time was at the beginning of the DVR window, as it starting seeking from time to time. This was due to currentTime of the player is updated at the 'timeupdate' event. This event can take up 250ms to be fired. Therefore, when checking if the currentTime is behind the DVR window size, the delayed of the event is taken into account.