Jump gaps feature #2418
Merged
Jump gaps feature #2418
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enable dash.js to jump over small time gaps in the stream. A gap is defined as small when it is shorter or equal to the limit defined with the
MediaPlayermethodsetSmallGapLimit. By default,smallGapLimitvalue is set to 0.8.By default jump gap feature is disabled. If you want to enable it you must use the
MediaPlayermethodsetJumpGaps.This PR also adds a new UI control to Dash Reference Player that allows the user to enable/disable jump gap feature with the UI. By default jump gaps feature is enabled for the Dash Reference Player.
Note: Some of the work done here is based on a PR previously sent by @WeiRen1991 (#2102). There were some things to fix there and some conflicts to resolve, so I preferred to sent a new PR and keep everything as cleaner as possible. Anyway, Thanks @Weirein1991 for your efforts and contribution.