Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow buffer removal when MediaSource is ended #2420

Merged

Conversation

epiclabsDASH
Copy link
Contributor

@epiclabsDASH epiclabsDASH commented Feb 13, 2018

Fix #2415.

In some situations, like when there are track changes, we have to allow the buffer to be removed even when it has reached the end of the stream. This PR adds the possibility of indicating to SourceBufferController that a buffer must be removed, independently of the playback context, and use it to force removal of buffers when there are track switches.

@epiclabsDASH epiclabsDASH added this to the v2.6.7 milestone Feb 13, 2018
@nicosang
Copy link
Contributor

according to the spec...

If the readyState attribute of the parent media source is in the "ended" state then run the following steps:

Set the readyState attribute of the parent media source to "open"
Queue a task to fire a simple event named sourceopen at the parent media source.

My question is : is there some troubles with this sourceopen event?

@epiclabsDASH
Copy link
Contributor Author

Good point. Currently that doesn't have any effect because the listener for sourceopen event is removed as soon as the first sourceopen event is received.

@epiclabsDASH epiclabsDASH merged commit 3654d59 into Dash-Industry-Forum:development Feb 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants