Add an event when a track change has rendered. #2440
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
src/streaming/MediaPlayerEvents.js
Outdated
| @@ -140,6 +140,12 @@ class MediaPlayerEvents extends EventsBase { | |||
| */ | |||
| this.QUALITY_CHANGE_RENDERED = 'qualityChangeRendered'; | |||
|
|
|||
| /** | |||
| * Triggered when the new track is being rendered on-screen. | |||
There was a problem hiding this comment.
Just a small correction. Given there are also audio track changes I would remove the "on-screen" part of the event description
davemevans
reviewed
Feb 27, 2018
index.d.ts
Outdated
| @@ -256,6 +256,7 @@ declare namespace dashjs { | |||
| PLAYBACK_TIME_UPDATED: 'playbackTimeUpdated'; | |||
| PROTECTION_CREATED: 'public_protectioncreated'; | |||
| PROTECTION_DESTROYED: 'public_protectiondestroyed'; | |||
| TRACK_CHANGE_RENDERED: 'trackChangeRequested'; | |||
There was a problem hiding this comment.
Shouldn't this be 'trackChangeRendered'?
|
@nweber, sorry, there are some conflicts to be resolved. Thanks |
…dash.js into track_switch_rendered_event
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This follows the already established method for identifying when a quality change has been rendered to allow us to dispatch an event when a track change has been rendered. This is helpful when switching audio or video tracks for UI feedback.