getRepresentationsForAdaptation optimization #2447
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epiclabsDASH
reviewed
Apr 4, 2018
| @@ -582,7 +582,7 @@ function StreamController() { | |||
|
|
|||
| if (mediaInfo) { | |||
| voAdaptation = adapter.getDataForMedia(mediaInfo); | |||
| useCalculatedLiveEdgeTime = dashManifestModel.getRepresentationsForAdaptation(voAdaptation)[0].useCalculatedLiveEdgeTime; | |||
| useCalculatedLiveEdgeTime = dashManifestModel.getRepresentationsForAdaptation(voAdaptation, 1)[0].useCalculatedLiveEdgeTime; | |||
There was a problem hiding this comment.
Given the requirement for setting the max number of representation requirements only comes from this line, I think could makes more sense adding a method to dashManifestModel that returns useCalculatedLiveEdgeTime of a given Adaptation and abstract StreamController of the way it should be calculated (useCalculatedLiveEdgeTime of the first representation of the adaptation). @Gontran-Molotov, what do you think?
|
Indeed, makes more sense. I'm going to make appropriate changes. |
Gontran-Molotov
force-pushed
the
optimizeGetRepresentationsForAdaptation
branch
from
2945b90
to
9cddda9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new
maxRepresentationsparameter toDashManifestModel.getRepresentationsForAdaptation(). It allows to specify how many representations to get. Currently, some classes callsgetRepresentationsForAdaptation()to uselessly get info for all representations but only use the first one, like inStreamController.onManifestUpdated().