Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fast-deep-equal #2448

Merged

Conversation

Gontran-Molotov
Copy link
Contributor

Use https://github.com/epoberezkin/fast-deep-equal for better performance in object comparison.

Copy link
Contributor

@nicosang nicosang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as unit tests about object equality are ok, no reason to not merge this PR.

Thanks,
Nico

@epiclabsDASH epiclabsDASH added this to the v2.6.7 milestone Mar 1, 2018
@epiclabsDASH epiclabsDASH merged commit 4dca12d into Dash-Industry-Forum:development Mar 1, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants