Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Play initialization #2457

Merged

Conversation

epiclabsDASH
Copy link
Contributor

Fix #2184

This PR changes the behavior of PlaybackController so it operates with VideoModel only in case PlaybackController was previously initialized and then there is an active stream. Otherwise, there are situations in which a call to MediaPlayer.play() before stream is initialized (and then the MediaSource associated) brings video element to an unstable state and some of its events are not fired (for example, the "play" event that is used to launch processes like the manifest update one). Example code to reproduce the issue:

player.initialize();
player.attachView(video);
player.attachSource(url);
player.play();

This is broken since v2.6.0. Dash.js v2.5.0 and before were working fine because they were establishing the video element during PlaybackController initialization.

@epiclabsDASH epiclabsDASH added this to the v2.6.7 milestone Mar 7, 2018
@epiclabsDASH epiclabsDASH merged commit 2d0de0a into Dash-Industry-Forum:development Mar 7, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants