Shift caption start time by MSETimeOffset * videoTimescale #2469
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@squarebracket, do you have a sample stream for testing? |
|
I'd have to get your IP temporarily added to our firewall as I'm testing with just a live stream. Or, I can get you a tarball of that live stream, if that would work. |
|
Yes, if you can send to me a tarball that would be perfect. |
|
To where can I send it? You can DM me on slack if appropriate. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In multiperiod dash feeds, the DTS gets reset to zero. The
timestampOffsetof the source buffer is correspondingly adjusted, but the caption start time is not. This PR simply fixes that by also adjusting the start time of captions.