New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimization of track addition #2475

Merged

epiclabsDASH merged 1 commit into Dash-Industry-Forum:development from MolotovTv:optimizeTrackAddition

Apr 16, 2018

Contributor

Gontran-Molotov commented Mar 16, 2018

This PR is a small optimization for the addition of tracks:

In Stream.initializeMediaForType():

remove call to MediaController.isMultiTrackSupportedByType() as it is also done in MediaController.addTrack()
fix: remove unused second argument passed to MediaController.addTrack()

The MediaController.addTrack() is also slightly refactored to:

return early if no track passed or track type is not suppored
use a direct reference to the track list to which passed track should be added.


          Optimization of track addition

4d1cbca

epiclabsDASH added the Code Refactor label

epiclabsDASH added this to the 2.6.8 milestone

epiclabsDASH merged commit 12f1059 into Dash-Industry-Forum:development

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment