Max value limited by portal size #2515
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
April 9, 2018 11:38
…h the max bitrate info checking maxBitrate and portal size
|
@dsparacio, this is covering the requirement you had regarding retrieving max bitrate limited by portal dimensions (in case limitByPortal is set to true). This new method is returning a BitrateInfo object, while all the other methods related with retrieving bitrate related config (getMaxAllowedBitrateFor, setInitialBitrate) return bitrates as numbers. Don't like too much breaking "homogeneity" (without reading doc I would expect a number) although in this case I am wonder if from the point of view of developer could be useful getting more details about the top bitrate than just its bits per second (ex: resolution). @dsparacio, what do you think? |
dsparacio
reviewed
May 9, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new method to the MediaPlayer to get the top quality BitrateInfo. It calls
getTopQualityIndexForinternally so portal size and max bitrate are checked. #2463