Fix #2525 - map one ISD to one Cue, not one Cue per content element #2549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r content element
|
I have been testing it exhaustively and everything was fine. @physicsforpoets, any feedback to share? As @bbcrddave said it would be nice having feedback as soon as possible so we can include the change into 2.6.8. |
|
@epiclabsDASH @bbcrddave this was the exact change I made in the debug player locally to attempt to fix the issue, looks good to me |
physicsforpoets
approved these changes
Apr 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ensures only ISDs with actual content are mapped to Cues, whilst only creating a single Cue per ISD. See #2525 for discussion.
I have tested with a number of the samples in the menu and also with some more complex (multiple active cues etc) content we have internally.
Please test and provide feedback ASAP so this has a chance to make it into 2.6.8.