Update not fragmented subtitles management #2610
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicosang
force-pushed
the
fix-NotFragmented-subtitles
branch
from
4855aa7
to
59f60b9
Compare
5 tasks
nicosang
force-pushed
the
fix-NotFragmented-subtitles
branch
from
6d4e567
to
8820186
Compare
|
This is awesome, and fixes my issue #2620 Any chance it can be in a 2.7.1 release? |
nicosang
force-pushed
the
fix-NotFragmented-subtitles
branch
from
8820186
to
39e381f
Compare
…ad subtitles data) only if this request has not been already downloaded.
nicosang
force-pushed
the
fix-NotFragmented-subtitles
branch
from
39e381f
to
f7b2cb3
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR has to optimize not fragmented subtitles management.
Indeed, when a stream is selected with not fragmented subtitle, like for instance https://vm2.dashif.org/dash/vod/testpic_2s/xml_subs.mpd, by default all the subtitles files are downloaded and parsed at the beginning. Then, if the user decides to seek somewhere in this content, the selected subtitle file is parsed a second time when this first seek command occurs.
So, these modifications allow to download only the selected subtitles file. Then, if the user wants to change subtitles track, the new file will be downloaded. Finally, if a seek command occurs, the useless parsing is not done.
Nico