Fix BUFFER_EMPTY never fired #2612
Merged
+37
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…istance, also will check buffer when native video element triggers stalled or playing
nicosang
reviewed
Jun 4, 2018
| @@ -553,7 +564,12 @@ function BufferController(config) { | |||
| } | |||
|
|
|||
| function notifyBufferStateChanged(state) { | |||
| if (bufferState === state || (type === Constants.FRAGMENTED_TEXT && !textController.isTextEnabled())) return; | |||
| if (bufferState === state || | |||
| (state === BUFFER_EMPTY && playbackController.getTime() === 0) || // Don't trigger BUFFER_EMPTY if it's initial loading | |||
There was a problem hiding this comment.
it's only for VOD streams?
There was a problem hiding this comment.
I think it should work in every stream, that check is only to avoid triggering BUFFER_EMPTY while loading the first segments
|
FYI, Chrome is deprecating |
|
@bbcrddave yes, the main issue was that it started as BUFFER_EMPTY, so if it never had enough buffer to be considered safe (12 seconds) and trigger BUFFER_LOADED, the state was always the same as the previous one and never fired. The two new events add more frequency to the buffer check, and that's good, but not the most important part. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix BUFFER_EMPTY never firing if buffer level never went above safe distance, also will check buffer when native video element triggers stalled or playing.
Fixes #2607