PlaybackController will end the stream if it's unfinished #2622
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ded but native element didn't trigger the ended event
aescarcha
force-pushed
the
fixStreamNotEnding
branch
from
3f84809
to
22adacc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ending the stream from PlaybackController when it's supposed to be ended but native element didn't trigger the ended event.
Sometimes the video element stops a few milliseconds before the stream end and the
endevent is never fired, but we do fire PLAYBACK_ENDED.Now we listen for that event in order to pause the player and stop the
wallclock intervalFixes #2593