Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore issue fixing in PR#2318 #2770

Conversation

bbert
Copy link
Contributor

@bbert bbert commented Sep 18, 2018

in ProtectionKeyController, restore issue fixing in PR #2318 that has been removed by error in PR #2451

@Murmur
Copy link

Murmur commented Oct 9, 2018

I cannot make a clearkeydrm embedded key:value working. Should this fix be available in a release or nightly build?

ClearkeyDRM(embedded key:value license key), not working
https://m.dtv.fi/dash/index_clearkey2b.html?video=21
uses https://reference.dashif.org/dash.js/nightly/dist/dash.all.debug.js script.

ClearkeyDRM(laurl php script license key), works ok
https://m.dtv.fi/dash/index_clearkey2.html?video=21
uses https://cdn.dashjs.org/latest/dash.all.debug.js script.

NoDRM test(free), works ok
https://m.dtv.fi/dash/index_clearkey2.html?video=2f

@nicosang
Copy link
Contributor

Hi @Murmur ,

I'm able to play your first stream by adding this line :

if (initData.constructor === Uint8Array) { in function createKeySession of ProtectionModel_21Jan2015 in order to not take into account the last encrypted event with a strange initData value.
So, it means the fix just above is not efficient enough.

Have you made any change to your protected streams that can explain this behavior?

Nico

@Murmur
Copy link

Murmur commented Oct 11, 2018

@nicosang No I have not updated the content(init.mp4, seg.m4s, manifest) it is what it's been all this time. I have never been able to dashjs playback ClearkeyDRM with an embedded key:value license key.

Both tests pages use this same manifest and video files.
https://m.dtv.fi/dash/dasherh264v2/drm/manifest_clearkey.mpd

ClearkeyDRM(embedded key:value license key), not working
https://m.dtv.fi/dash/index_clearkey2b.html?video=21
ClearkeyDRM(laurl php script license key), works ok
https://m.dtv.fi/dash/index_clearkey2.html?video=21

@nicosang
Copy link
Contributor

ok, I understand...So, would you like, please, register a new issue with all your sample streams?
This PR had the regression tag that it is not the case of your problem....In a second time, I will provide a PR with my small fix described above.

Thanks,
Nico

@Murmur
Copy link

Murmur commented Oct 15, 2018

@nicosang Did you see my #2806 issue ticket? thx.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants