Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix ABR controller if min allowed bitrate is set #3002

Conversation

bbert
Copy link
Contributor

@bbert bbert commented Jun 14, 2019

Before the fix:

  • set min allowed bitrate on player, for example 500kb/s
  • start a new stream
  • ABR controller selects highest quality as initial bitrate, for example 2Mb/s, since previous bitrate stored in local storage is high

=> then at first pass in ABR controller before downloading 1st video segment:

  • no rule is applied
  • a switch request with NO_CHANGE quality (=-1) is applied
  • this quality (-1) is compared to min allowed quality
  • since -1 < min allowed quality, min allowed quality is selected instead of highest quality

This PR fixes this issue.

Additionnaly, this PR adds the possibility to set min and max video bitrate in the options of the dash-if-reference-player sample webapp.
And it fixes also the assignement of ABR settings in the webapp.

Bertrand Berthelot added 3 commits June 14, 2019 13:16
- add possiblity to set min video bitrate parameter value
- fix abr settings
- add possiblity to set max video bitrate parameter value
@bbert bbert added the Bug label Jun 14, 2019
@epiclabsDASH epiclabsDASH added this to the v3.0 milestone Jun 18, 2019
@epiclabsDASH epiclabsDASH merged commit 00e32ae into Dash-Industry-Forum:development Jun 18, 2019
@nicosang nicosang deleted the fix-abr-min-allowed-bitrate branch June 18, 2019 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants