fix issue about media finished detection #3116
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR has to update PR #3105 that included a regression about media finished detection. In dynamic manifest use case, dashHandler has to keep segmentIndex unchanged if no request has been found. In static manifest, in order to detect media finished status, segmentIndex has to be increased by one to be equals or greater than availableSegmentsNumber.
So, the stream https://livesim.dashif.org/livesim/modulo_10/testpic_2s/Manifest.mpd can be used to test that the previsous PR is always solved by this new PR. The first VOD stream in the sample page can be used to be sure that the end of the stream is correctly detected.
Nico