Fix Issue #3083 for live streams with multiperiod. #3154
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
5 tasks
5 tasks
|
@jeremco : Thanks for that fix, works well with the DASH-IF stream. I will merge that for now, nevertheless we should keep in mind that the _ isSegmentAvailable_ function does not work properly. In my opinion periodEnd and periodRelativeEnd should consider multiperiod manifests as well. |
|
@dsilhavy : I agree with you. This function has been added in 3.0.0. We don't know why and for which cases it has been added. |
Closed
5 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi
This PR solves the issue #3083.
The pb was that introduced function in 3.0.0, SegmentUtils::isSegmentAvailable was returning false in case of multiperiod streams if segment time was not found in current period. For live streams, play was never started, because no request was available at startTime
Jérémie