Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove default value in typeScript #3162

Merged
merged 1 commit into from Jan 17, 2020
Merged

Remove default value in typeScript #3162

merged 1 commit into from Jan 17, 2020

Conversation

nicosang
Copy link
Contributor

Hi,

this PR has to solve issue #3156.

@mcereijo, could you, please, take a look?

Nico

@nicosang nicosang added the Bug label Jan 15, 2020
@mcereijo
Copy link

Hi,

this PR has to solve issue #3156.

@mcereijo, could you, please, take a look?

Nico

I just checked the code and tested it. It looks like it is working.

Good job!

@dsilhavy dsilhavy added this to the 3.0.2 milestone Jan 15, 2020
@dsilhavy dsilhavy self-requested a review January 15, 2020 09:42
@dsilhavy
Copy link
Collaborator

Remark: Close #3125 as well when merged

@dsilhavy dsilhavy merged commit eab99e0 into Dash-Industry-Forum:development Jan 17, 2020
This was referenced Jan 17, 2020
Closed
Closed
@nicosang nicosang deleted the typeScriptBugFix branch January 17, 2020 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsilhavy dsilhavy Awaiting requested review from dsilhavy

Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nicosang @mcereijo @dsilhavy