Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix regression with enableText #3286

Merged
merged 3 commits into from Jun 12, 2020
Merged

Fix regression with enableText #3286

merged 3 commits into from Jun 12, 2020

Conversation

jeffcunat
Copy link
Contributor

As with PR #3245, we now disable text by default, we have introduced a regression. Using enableText(true) does nothing if setTextDefaultEnabled is not set to true.

This PR

  • fix this regression
  • allows us to call enableText(true/false) even before text tracks are added
  • enable text by default in sample multi-track-captions.html

@dsilhavy dsilhavy added this to the 3.1.2 milestone Jun 12, 2020
@dsilhavy dsilhavy merged commit 40f25dd into Dash-Industry-Forum:development Jun 12, 2020
@bbert bbert deleted the fixRegressionEnableText branch June 12, 2020 13:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsilhavy dsilhavy dsilhavy left review comments

Assignees
No one assigned
Labels
Regression
Projects
None yet
Milestone
3.1.2
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeffcunat @dsilhavy