dvb:probability should be 1000 by default #3414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If dvb:probability is absent in the Metric's Reporting descriptor it should default to 1000 (a reporting player) as per DVB spec (Clause 10.12.3.3). The typo that referenced dvb:priority instead of dvb:priority has been corrected in the DVB spec now for some time and it's probably fair (and safe) to remove the fallback to this.
Made some changes to be more explicit about attribute names and default values. I based these on how the DVB extensions are handled for BaseURL elements.
Straight off the bat, I work for the BBC and you should be able to see I'm part of the BBC's organisation on Github. We signed the CLA in 2014 (point 4):
https://github.com/Dash-Industry-Forum/dash.js/wiki/Meeting-Minutes#minutes-april-4th-2014