Implementation of MPEG-DASH 5th Edition Patching Semantics #3451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Full support for DASH specified xpath restrictions - Support for add/replace/delete operations in patch - Validation of Patch on receive - Handling of empty Patch semantics This commit is rebased first pass on to latest dash.js, includes the additional fixes previously provided: - Patch operation ironing fix (#1) - @thmatuza - Xpath indexing and add attribute operation (#2) - @chanyk-joseph
technogeek00
commented
Nov 12, 2020
…dash.js into mpd-patch-updates � Conflicts: � test/unit/mocks/AdapterMock.js
dsilhavy
reviewed
Jan 25, 2021
dsilhavy
reviewed
Jan 26, 2021
|
Thanks @dsilhavy I'll get these implemented |
technogeek00
commented
Feb 8, 2021
bbert
added a commit
to Orange-OpenSource/dash.js
that referenced
this pull request
Feb 10, 2021
…d remove _asArray nodes)
Closed
bbert
added a commit
to Orange-OpenSource/dash.js
that referenced
this pull request
Feb 10, 2021
…d remove _asArray nodes)
bbert
added a commit
to Orange-OpenSource/dash.js
that referenced
this pull request
Feb 10, 2021
…d remove _asArray nodes)
bbert
added a commit
to Orange-OpenSource/dash.js
that referenced
this pull request
Apr 16, 2021
dsilhavy
pushed a commit
that referenced
this pull request
Jun 21, 2023
* update package-lock.json * add txml parser dependency * DashParser: use txml parser and add post-processing to simplify xml tree and manage node as arrays * remove '_asArray' notation * DashParser: fix processAttr() * add tXml in externals and remove from dependencies, to avoid uglify issue with ES6 syntax * XlinkController: use parser (tXml) from DashParser * DashParser: handle parsing failure * MssParser: complete _asArray removal * update unit tests * update DashConstants * Modify tXml to apply simplification proces (including attributes and nodes as array process) on-the-fly * Remove StringMatcher * update according to PR #3451 (update xml parser and remove _asArray nodes) * update according to PR #3451 (update xml parser and remove _asArray nodes) * update according to PR #3451 (update xml parser and remove _asArray nodes) * Dash parser: add missing nodes (as array) PatchLocation, replace, add and remove * complete update according to PR #3451 * tXml: init attrMatchers as an array * tXml: add attributes matchers and nodes as array in options parameter * Fixed DashManifestModel.getLocation() * Fixed DashManifestModel.getPatchLocation() * Remove unuseful existence check on elements assumed to be as arrays * Remove unuseful existence check on elements assumed to be as arrays * DashAdapter::applyPatchToManifest(): check types of nodes (object vs array) * update package-lock.json * SimpleXPath: check id leaf element is array or not * Remove remaining asArray after rebase * Fix unit tests * tXml: add suport for tag namespace * Merge branch 'development' into xml-parser * xml parser: complete asArray removal * xml parser: fix samples * xml parser: fix regression after merge * Update tXml parser to v4.0.1 * Modify tXml parser Re-apply modifications to tXml parser library in order to: - add child node to their parent as arrays or object according to node names - process attributes on the fly - set node text value in "_text" property * Update DashParser according to new version of tXml * UTCTiming to be stored as an array * NumericMatcher: do not apply on attributes specified as string but that can contain a number value (such as "id" attribute) * Remove StringMatcher * Fix merge for LangMatcher * Remove files * Fix typeof object * DashAdapter: fix applyPatchToManifest() to distinguish array from non-array elements * Remove xml2json * Fix merge * Fix InbandEventStream node being as an array
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'd like to highlight this commit includes a roll-up of additional fixes previously provided as part of forward porting from v2 to v3 of DASH.js (thanks to both!):