add missing ABR strategies to TypeScript defs #3480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @slhck . Following our contribution guidelines, and since this seems to be your first PR, could you please send me a signed copy of dash.js feedback agreement? |
|
Sure. I submitted a request to join the mailing list and will send it there once approved. |
|
where I can find the source code the dynamic 'abrDynamic' algorithm that groups both BOLA and TROUGHPUT |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the following ABR strategies to the TypeScript definitions, since I assume they're all customizable from the settings:
abrDynamicabrBolaabrL2AabrLoLPabrThroughputOr are they only available in some specific circumstances?