Add "highestEfficiency" initial track selection mode #3498
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsilhavy
reviewed
Jan 7, 2021
|
This looks very good, only had one minor question. We can merge this afterwards |
robertbryer
pushed a commit
to bbc/dash.js
that referenced
this pull request
Jan 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new initial track selection mode: "highestEfficiency". It picks the variant that offers the lowest bitrate for equivalent resolution (similar to the Shaka Player behavior referenced by @japettyjohn in #3022 (comment)). Similar to Shaka Player, this will prefer VP9 over MP4 if it's offered with a lower average bitrate, which is the behavior I was looking for.
In addition, this PR exposes
selectInitialTrackand thegetTracksWithHighestBitrate/etc functions on the class factory so that they can be overridden usingMediaPlayer.extend, to allow end users to define their own custom strategy.Included are new tests to cover the new track selection mode as well as the other existing ones.
Re: #3022