Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Account for schemeIdUri, value and id fields in EventController #3504

Merged
merged 3 commits into from
Jan 6, 2021
Merged

Fix: Account for schemeIdUri, value and id fields in EventController #3504

merged 3 commits into from
Jan 6, 2021

Conversation

dsilhavy
Copy link
Collaborator

@dsilhavy dsilhavy commented Jan 6, 2021

This PR aims to fix the issue described in #3485 and #3429:

  • The events are now sorted by schemeIdUri and not by id.
  • Existing events are only overwritten for similar schemeId, value and id field values
  • Events are added if they have similar ids, similar schemeIdUris but different values
  • Added additional unit tests
  • Fixed a bug in the calculation of Version 1 inband events. Use the PTO from the element instead of the one from the element

@dsilhavy dsilhavy added this to the 3.2.1 milestone Jan 6, 2021
@dsilhavy dsilhavy merged commit 9c2dad3 into Dash-Industry-Forum:development Jan 6, 2021
This was referenced Jan 6, 2021
Closed
Closed
@dsilhavy dsilhavy deleted the fix-3485 branch June 26, 2021 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@dsilhavy