Add feature for filtering license requests and responses #3535
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsilhavy
reviewed
Feb 15, 2021
| @@ -401,6 +405,8 @@ function MediaPlayer() { | |||
| */ | |||
| function destroy() { | |||
| reset(); | |||
| licenseRequestFilters = []; | |||
There was a problem hiding this comment.
Should we move this to the reset() function?
There was a problem hiding this comment.
If we can attach new source after reset(), I would say no. We should keep the filters until player is destroyed
added 2 commits
February 15, 2021 15:21
This was referenced Feb 16, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new feature on MediaPlayer to enable filtering license requests and responses