Fix internal seek #3536
Merged
Fix internal seek #3536
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 15, 2021 17:10
…me has been set (do not wait for 'seeked' event)
…re next 'seeking' event after internal seek, so that concurrent user seeks can be considered (without waiting for 'seeked' event)
bbert
pushed a commit
to Orange-OpenSource/dash.js
that referenced
this pull request
Mar 4, 2021
* When doing internal seek, re-enable 'seeking' listener once currentTime has been set (do not wait for 'seeked' event) * for internal seek, do not disable 'seeking' listener, but simply ignore next 'seeking' event after internal seek, so that concurrent user seeks can be considered (without waiting for 'seeked' event)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When doing internal seek (to adjust seek target or to jump gaps), re-enable 'seeking' listener once currentTime has been set on video element (do not wait for 'seeked' event).
This fixes some inconsistancies when user is seeking while internal seeking