fix: #3558

[orange4glace]

fix #3558

Set buffering time to last quota exceeded segment time on QuotaExceededError occurs

[dsilhavy]

@orange4glace Thanks for this PR.

Following our contribution guidelines, and since this seems to be your first PR, could you please send me a signed copy of dash.js feedback agreement?

[orange4glace]

Thanks for the response, @dsilhavy !
I've uploaded my agreement here. https://groups.google.com/g/dashjs/c/3613JLAYdG4

[dsilhavy]

@orange4glace In your tests did you verify that this does not interfere with the logic that is applied after the buffer has been cleared? In StreamProcessor.onBufferCleared:

 // If buffer removed ahead current time (QuotaExceededError or automatic buffer pruning) then adjust current index handler time

 if (e.from > playbackController.getTime()) {
            bufferingTime = e.from;
            bufferPruned = true;
 }

[orange4glace]

Currently, clearBuffers(getClearRanges()) fires after QUOTA_EXCEEDED is triggered.
Even though, since getClearRanges() returns ranges only before the currentTime, it seems that there's no chance that if (e.from > playbackController.getTime()) and QUOTA_EXCEEDED occurs simultaneously at least in the current codebase.

            if (e.error.code === QUOTA_EXCEEDED_ERROR_CODE || !hasEnoughSpaceToAppend()) {
                logger.warn('Clearing playback buffer to overcome quota exceed situation');
                // Notify Schedulecontroller to stop scheduling until buffer has been pruned
                triggerEvent(Events.QUOTA_EXCEEDED, {
                    criticalBufferLevel: criticalBufferLevel,
                    quotaExceededTime: e.chunk.start
                });
                clearBuffers(getClearRanges());
            }