Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix multiperiod switching #3581

Merged

Conversation

bbert
Copy link
Contributor

@bbert bbert commented Mar 17, 2021

This PR is fixing some issues when switching periods, due to controllers lifecycle and seeking event handler.
For example it fixes the following javascript error when switching period:

BufferController.js:398 Uncaught TypeError: Cannot read property 'waitForUpdateEnd' of null
    at pruneAllSafely (BufferController.js:398)
    at Object.onPlaybackSeeking (BufferController.js:386)
    at EventBus.js:124
    at Array.forEach (<anonymous>)
    at Object.trigger (EventBus.js:124)
    at HTMLVideoElement.onPlaybackSeeking (PlaybackController.js:499)

@bbert bbert added the Bug label Mar 17, 2021
@dsilhavy dsilhavy added this to the 3.3.0 milestone Mar 29, 2021
@dsilhavy dsilhavy merged commit 84c552e into Dash-Industry-Forum:development Mar 30, 2021
@bbert bbert deleted the fix-multi-periods branch April 7, 2021 11:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants